Re: [PATCH 4/4] blk-mq: use blk_queue_enter/exit to protect debugfs file creation
From: Christoph Hellwig <hch@lst.de>
Date: 2026-02-10 15:41:53
Also in:
asahi, linux-block, linux-nvme
From: Christoph Hellwig <hch@lst.de>
Date: 2026-02-10 15:41:53
Also in:
asahi, linux-block, linux-nvme
On Mon, Feb 09, 2026 at 10:33:15AM -0700, Keith Busch wrote:
quoted
This is not clear to me. Why are concurrent queue freezes not allowed while debugfs attributes are created? I don't see any code in debugfs that calls back into the block layer while creating debugfs attributes? Did I perhaps overlook something?I had to look up the original commit that introduced the WARN, 65d466b629847. The commit message says "Creating new debugfs entries can trigger fs reclaim", so that must be the path that enters back into the blaock layer request_queue.
Another way to solves this would be to scope all the debugs action as NOIO context.