Re: [PATCH v3 1/3] media: dt-bindings: rockchip,vdec: Add alternative reg-names order for RK35{76,88}
From: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Date: 2026-02-26 19:25:48
Also in:
linux-devicetree, linux-media, linux-rockchip, lkml
Le mercredi 25 février 2026 à 14:19 +0200, Cristian Ciocaltea a écrit :
With the introduction of the RK3588 SoC, and RK3576 afterwards, the 'link' and 'cache' register blocks have been provided for the video decoder unit in addition to the existing 'function' one, which now shows up in between them (from address-based ordering point of view). However, the binding does not properly describe this hardware layout, as the new blocks are listed after the old one. Therefore it breaks the convention expecting the unit address to indicate the first register range. Since the binding changes have been already released and a fix would bring up an ABI break, mark the current 'reg-names' listing as deprecated and introduce an alternative 'link,function,cache' one. Additionally, drop the 'reg' description items as the order is not fixed anymore, while the information they offer is not very relevant anyway. Signed-off-by: Cristian Ciocaltea <redacted>
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
quoted hunk ↗ jump to hunk
--- .../devicetree/bindings/media/rockchip,vdec.yaml | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-)diff --git a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml index 809fda45b3bd..3f6072e8baa5 100644 --- a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml +++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml@@ -28,16 +28,21 @@ properties:reg: minItems: 1 - items: - - description: The function configuration registers base - - description: The link table configuration registers base - - description: The cache configuration registers base + maxItems: 3 reg-names: - items: + oneOf: - const: function - - const: link - - const: cache + - items: + - const: link + - const: function + - const: cache + - items: + - const: function + - const: link + - const: cache + deprecated: true + description: Use link,function,cache block order instead. interrupts: maxItems: 1
Attachments
- signature.asc [application/pgp-signature] 228 bytes