Re: [PATCH 14/14] drm/display: hdmi: Use drm_output_color_format instead of hdmi_colorspace
From: Jani Nikula <jani.nikula@linux.intel.com>
Date: 2026-02-24 12:43:52
Also in:
amd-gfx, dri-devel, linux-mediatek, linux-rockchip, linux-sunxi, lkml
On Tue, 24 Feb 2026, Maxime Ripard [off-list ref] wrote:
quoted hunk ↗ jump to hunk
diff --git a/include/drm/display/drm_hdmi_helper.h b/include/drm/display/drm_hdmi_helper.h index 09145c9ee9fc0cd839242f2373b305940e06e157..414e134ca23bcdcdd6ef491812ed0a9020b204ba 100644 --- a/include/drm/display/drm_hdmi_helper.h +++ b/include/drm/display/drm_hdmi_helper.h@@ -2,10 +2,11 @@ #ifndef DRM_HDMI_HELPER #define DRM_HDMI_HELPER #include <linux/hdmi.h> +#include <drm/drm_connector.h>
You could avoid the include by forward declaring the enum, which is not strictly standard C but allowed by both GCC and Clang, and quite useful in reducing header dependencies. BR, Jani.
quoted hunk ↗ jump to hunk
struct drm_connector; struct drm_connector_state; struct drm_display_mode;@@ -24,11 +25,11 @@ drm_hdmi_infoframe_set_hdr_metadata(struct hdmi_drm_infoframe *frame, void drm_hdmi_avi_infoframe_content_type(struct hdmi_avi_infoframe *frame, const struct drm_connector_state *conn_state); unsigned long long drm_hdmi_compute_mode_clock(const struct drm_display_mode *mode, - unsigned int bpc, enum hdmi_colorspace fmt); + unsigned int bpc, enum drm_output_color_format fmt); void drm_hdmi_acr_get_n_cts(unsigned long long tmds_char_rate, unsigned int sample_rate, unsigned int *out_n,
-- Jani Nikula, Intel