Re: [PATCH 1/3] phy: apple: atc: Make atcphy_dwc3_reset_ops variable static
From: Janne Grunau <j@jannau.net>
Date: 2026-02-24 07:57:08
Also in:
asahi, linux-arm-msm, linux-phy, lkml
From: Janne Grunau <j@jannau.net>
Date: 2026-02-24 07:57:08
Also in:
asahi, linux-arm-msm, linux-phy, lkml
On Mon, Feb 16, 2026 at 12:04:14PM +0100, Krzysztof Kozlowski wrote:
File-scope 'atcphy_dwc3_reset_ops' is not used outside of this unit, so make it static to silence sparse warning: atc.c:2026:32: warning: symbol 'atcphy_dwc3_reset_ops' was not declared. Should it be static? Signed-off-by: Krzysztof Kozlowski <redacted> --- drivers/phy/apple/atc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/phy/apple/atc.c b/drivers/phy/apple/atc.c index dc867f368b68..32d97226e926 100644 --- a/drivers/phy/apple/atc.c +++ b/drivers/phy/apple/atc.c@@ -2023,7 +2023,7 @@ static int atcphy_dwc3_reset_deassert(struct reset_controller_dev *rcdev, unsign return 0; } -const struct reset_control_ops atcphy_dwc3_reset_ops = { +static const struct reset_control_ops atcphy_dwc3_reset_ops = { .assert = atcphy_dwc3_reset_assert, .deassert = atcphy_dwc3_reset_deassert, };
Reviewed-by: Janne Grunau <j@jannau.net> thanks Janne