Re: [PATCH v2 1/3] media: dt-bindings: rockchip,vdec: Correct reg-names order for RK35{76,88}
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2026-02-24 07:17:54
Also in:
linux-devicetree, linux-media, linux-rockchip, lkml
On Mon, Feb 23, 2026 at 09:49:49PM +0200, Cristian Ciocaltea wrote:
Update 'reg-names' property to allow providing the register blocks in the expected address-based order for RK3576 & RK3588 video decoder and,
What? The register blocks SHOULD NOT be provided in address-based order. There was never such coding style, never ever we gave such hint and if you found Qcom discussions you would see me and Rob objecting to it.
consequently, fix some DTC warnings.
Additionally, drop the 'reg' description items as the order is not fixed
anymore, while the information they offer is not very relevant anyway.
Fixes: c6ffb7e1fb90 ("media: dt-bindings: rockchip: Document RK3588 Video Decoder bindings")
Fixes: a5c4a6526476 ("media: dt-bindings: rockchip: Add RK3576 Video Decoder bindings")No, nothing to be fixed here. Describe the bug, because missing order to address-based is for sure not a bug.
quoted hunk ↗ jump to hunk
Signed-off-by: Cristian Ciocaltea <redacted> --- Documentation/devicetree/bindings/media/rockchip,vdec.yaml | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-)diff --git a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml index 809fda45b3bd..2d3164a2882b 100644 --- a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml +++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml@@ -28,16 +28,15 @@ properties: reg: minItems: 1 - items: - - description: The function configuration registers base - - description: The link table configuration registers base - - description: The cache configuration registers base + maxItems: 3 reg-names: - items: + oneOf: - const: function - - const: link - - const: cache + - items: + - const: link + - const: function + - const: cache
No, ABI break without point.
interrupts:
maxItems: 1
--
2.52.0