Thread (25 messages) 25 messages, 6 authors, 2026-03-05

Re: [PATCH 3/9] power: supply: max77705: Free allocated workqueue and fix removal order

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2026-02-23 11:29:11
Also in: chrome-platform, driver-core, linux-doc, linux-mediatek, linux-pm, lkml

On Mon, Feb 23, 2026 at 11:19:13AM +0100, Krzysztof Kozlowski wrote:
On 23/02/2026 09:57, Andy Shevchenko wrote:
quoted
On Mon, Feb 23, 2026 at 08:27:31AM +0100, Krzysztof Kozlowski wrote:
...
quoted
quoted
 	ret = devm_request_threaded_irq(dev, regmap_irq_get_virq(irq_data, MAX77705_CHGIN_I),
 					NULL, max77705_chgin_irq,
 					IRQF_TRIGGER_NONE,
 					"chgin-irq", chg);
-	if (ret) {
-		dev_err_probe(dev, ret, "Failed to Request chgin IRQ\n");
-		goto destroy_wq;
-	}
+	if (ret)
+		return dev_err_probe(dev, ret, "Failed to Request chgin IRQ\n");
This should be just

		return ret;


devm_*_irq() prints the message. No need to repeat this in the caller(s).
I guess separate commit then.
WFM!

-- 
With Best Regards,
Andy Shevchenko


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help