Thread (8 messages) 8 messages, 3 authors, 2026-03-07

Re: [PATCH] ARM: tegra: paz00: configure WiFi rfkill switch through device tree

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2026-02-23 04:57:55
Also in: linux-devicetree, linux-tegra, lkml

Hi Marc,

On Sat, Feb 21, 2026 at 03:24:35PM +0100, Marc Dietrich wrote:
Hi Dmitry,

On Sat, 14 Feb 2026, Marc Dietrich wrote:
quoted
Hi Dmitry,

On Fri, 13 Feb 2026, Dmitry Torokhov wrote:
quoted
As of d64c732dfc9e ("net: rfkill: gpio: add DT support") rfkill-gpio
device can be instantiated via device tree.

Add the declaration there and drop board-paz00.c file and relevant
Makefile fragments.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---

This is not tested on real hardware, compile tested only...

arch/arm/boot/dts/nvidia/tegra20-paz00.dts |  8 ++++
arch/arm/mach-tegra/Makefile               |  2 -
arch/arm/mach-tegra/board-paz00.c          | 56 ----------------------
arch/arm/mach-tegra/board.h                |  2 -
arch/arm/mach-tegra/tegra.c                |  4 --
5 files changed, 8 insertions(+), 64 deletions(-)
diff --git a/arch/arm/boot/dts/nvidia/tegra20-paz00.dts
b/arch/arm/boot/dts/nvidia/tegra20-paz00.dts
index 1408e1e00759..d1093ad569e6 100644
--- a/arch/arm/boot/dts/nvidia/tegra20-paz00.dts
+++ b/arch/arm/boot/dts/nvidia/tegra20-paz00.dts
@@ -706,6 +706,14 @@ vdd_pnl_reg: regulator-3v0 {
		enable-active-high;
	};

+	rfkill {
+		compatible = "rfkill-gpio";
+		label = "wifi_rfkill";
+		radio-type = "wlan";
+		reset-gpios = <&gpio TEGRA_GPIO(D, 1) GPIO_ACTIVE_HIGH>;
I guess this can be removed, as it should trigger the LED, which is
already included elsewhere ....
quoted
+		shutdown-gpios = <&gpio TEGRA_GPIO(K, 5) GPIO_ACTIVE_HIGH>;
+	};
+
	sound {
		compatible = "nvidia,tegra-audio-alc5632-paz00",
			"nvidia,tegra-audio-alc5632";
I'll give it a try and report back.
rfkill (and LED) works as expected. With the reset-gpio line mentioned above
removed, you can add my Tested-By.
Thank you Marc.

I am still a bit confused about the reset gpio. As far as I understand
looking through old commits reset gpio (PD1) is distinct from the LED
gpio (PD0) that is currently being controlled by "gpio-leds".

I guess the rfkill driver needs at least one of "reset" or "shutdown"
gpios, and that is why it continues to work with only shutdown, but I am
trying to understand if PD1 was never connected to the WiFi chip reset
line and instead is used for something else, or if it is indeed a reset
line...

Was the patch not working with reset-gpios present? I am trying to
gather data to craft a proper commit message.

Thanks.

-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help