Re: [PATCH 2/5] iio: adc: xilinx-xadc: Add setup_channels function pointer... | linux-arm-kernel

[PATCH 0/5] iio: adc: xilinx-xadc: Add I2C interface support for System Management Wizard · Sai Krishna Potthuri <sai.krishna.potthuri@amd.com> · 2026-02-20
[PATCH 1/5] iio: adc: xilinx-xadc: Add helper functions for the device setup · Sai Krishna Potthuri <sai.krishna.potthuri@amd.com> · 2026-02-20
Re: [PATCH 1/5] iio: adc: xilinx-xadc: Add helper functions for the device setup · Andy Shevchenko <hidden> · 2026-02-20
[PATCH 2/5] iio: adc: xilinx-xadc: Add setup_channels function pointer to ops structure · Sai Krishna Potthuri <sai.krishna.potthuri@amd.com> · 2026-02-20
Re: [PATCH 2/5] iio: adc: xilinx-xadc: Add setup_channels function pointer to ops structure · Andy Shevchenko <hidden> · 2026-02-20
[PATCH 3/5] iio: adc: xilinx-xadc: Replace module macro with custom init/exit functions · Sai Krishna Potthuri <sai.krishna.potthuri@amd.com> · 2026-02-20
Re: [PATCH 3/5] iio: adc: xilinx-xadc: Replace module macro with custom init/exit functions · Andy Shevchenko <hidden> · 2026-02-20
Re: [PATCH 3/5] iio: adc: xilinx-xadc: Replace module macro with custom init/exit functions · Michal Simek <michal.simek@amd.com> · 2026-02-20
Re: [PATCH 3/5] iio: adc: xilinx-xadc: Replace module macro with custom init/exit functions · Andy Shevchenko <hidden> · 2026-02-20
Re: [PATCH 3/5] iio: adc: xilinx-xadc: Replace module macro with custom init/exit functions · Sai Krishna Potthuri <sai.krishna.potthuri@amd.com> · 2026-03-18
Re: [PATCH 3/5] iio: adc: xilinx-xadc: Replace module macro with custom init/exit functions · Andy Shevchenko <hidden> · 2026-03-18
[PATCH 4/5] iio: adc: xilinx-xadc: Add I2C interface support · Sai Krishna Potthuri <sai.krishna.potthuri@amd.com> · 2026-02-20
Re: [PATCH 4/5] iio: adc: xilinx-xadc: Add I2C interface support · Andy Shevchenko <hidden> · 2026-02-20
[PATCH 5/5] dt-bindings: iio: adc: xilinx-xadc: convert to YAML format · Sai Krishna Potthuri <sai.krishna.potthuri@amd.com> · 2026-02-20
Re: [PATCH 5/5] dt-bindings: iio: adc: xilinx-xadc: convert to YAML format · Krzysztof Kozlowski <krzk@kernel.org> · 2026-02-21
Re: [PATCH 5/5] dt-bindings: iio: adc: xilinx-xadc: convert to YAML format · Sai Krishna Potthuri <sai.krishna.potthuri@amd.com> · 2026-03-19
Re: [PATCH 5/5] dt-bindings: iio: adc: xilinx-xadc: convert to YAML format · David Lechner <dlechner@baylibre.com> · 2026-03-19
Re: [PATCH 5/5] dt-bindings: iio: adc: xilinx-xadc: convert to YAML format · Sai Krishna Potthuri <sai.krishna.potthuri@amd.com> · 2026-03-19
Re: [PATCH 5/5] dt-bindings: iio: adc: xilinx-xadc: convert to YAML format · David Lechner <dlechner@baylibre.com> · 2026-03-19
Re: [PATCH 5/5] dt-bindings: iio: adc: xilinx-xadc: convert to YAML format · Sai Krishna Potthuri <sai.krishna.potthuri@amd.com> · 2026-03-19
Re: [PATCH 5/5] dt-bindings: iio: adc: xilinx-xadc: convert to YAML format · David Lechner <dlechner@baylibre.com> · 2026-03-19
Re: [PATCH 5/5] dt-bindings: iio: adc: xilinx-xadc: convert to YAML format · Sai Krishna Potthuri <sai.krishna.potthuri@amd.com> · 2026-03-19
Re: [PATCH 5/5] dt-bindings: iio: adc: xilinx-xadc: convert to YAML format · Krzysztof Kozlowski <krzk@kernel.org> · 2026-03-19
Re: [PATCH 5/5] dt-bindings: iio: adc: xilinx-xadc: convert to YAML format · David Lechner <dlechner@baylibre.com> · 2026-03-19
Re: [PATCH 5/5] dt-bindings: iio: adc: xilinx-xadc: convert to YAML format · Krzysztof Kozlowski <krzk@kernel.org> · 2026-03-22
Re: [PATCH 5/5] dt-bindings: iio: adc: xilinx-xadc: convert to YAML format · Krzysztof Kozlowski <krzk@kernel.org> · 2026-02-21
Re: [PATCH 0/5] iio: adc: xilinx-xadc: Add I2C interface support for System Management Wizard · Andy Shevchenko <hidden> · 2026-02-20

Re: [PATCH 2/5] iio: adc: xilinx-xadc: Add setup_channels function pointer to ops structure

From: Andy Shevchenko <hidden>
Date: 2026-02-20 07:52:23
Also in: linux-devicetree, linux-iio, lkml

On Fri, Feb 20, 2026 at 11:09:38AM +0530, Sai Krishna Potthuri wrote:

Add setup_channels function pointer to xadc_ops structure to enable

Add .setup_channels()...

...to struct xadc_ops to enable...

different interfaces to have custom channel setup logic.

...

+static int xadc_parse_dt(struct iio_dev *indio_dev, unsigned int *conf, int irq);

This is a red flag. Why do we need a forward declaration? Bad architecture /
design of the function calls?

-- 
With Best Regards,
Andy Shevchenko

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help