Re: [PATCH 5/5] drivers: clk: mediatek: Fix error finding regmap
From: Laura Nao <hidden>
Date: 2026-02-10 16:15:11
Also in:
linux-clk, linux-mediatek, linux-pm, lkml
Hi, On 2/10/26 06:37, Adam Ford wrote:
quoted hunk ↗ jump to hunk
The clock driver for clk-mt8196-vdisp-ao doesn't use the same common clk functions that other clocks use. As such, this clock returns an error: Cannot find regmap for /soc: -ENOMEM clk-mt8196-vdisp-ao 3e800000.syscon: probe with driver clk-mt8196-vdisp-ao failed with error -12 Fix this by using the common clock calls. With this patch, the following new clocks properly enumerate: mm_v_disp_vdisp_ao_config mm_v_disp_dpc mm_v_smi_sub_somm0 Fixes: d4fb7e15a520 ("clk: mediatek: Add MT8196 disp-ao clock support") Signed-off-by: Adam Ford <redacted> --- drivers/clk/mediatek/clk-mt8196-vdisp_ao.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/clk/mediatek/clk-mt8196-vdisp_ao.c b/drivers/clk/mediatek/clk-mt8196-vdisp_ao.c index fddb69d1c3eb..070c60f40b64 100644 --- a/drivers/clk/mediatek/clk-mt8196-vdisp_ao.c +++ b/drivers/clk/mediatek/clk-mt8196-vdisp_ao.c@@ -67,8 +67,8 @@ static const struct of_device_id of_match_clk_mt8196_vdisp_ao[] = { MODULE_DEVICE_TABLE(of, of_match_clk_mt8196_vdisp_ao); static struct platform_driver clk_mt8196_vdisp_ao_drv = { - .probe = mtk_clk_pdev_probe, - .remove = mtk_clk_pdev_remove, + .probe = mtk_clk_simple_probe, + .remove = mtk_clk_simple_remove, .driver = { .name = "clk-mt8196-vdisp-ao", .of_match_table = of_match_clk_mt8196_vdisp_ao,
This driver is actually expected to be registered by the mtk-mmsys driver via platform_device_register_data() (related changes are in a pending series [1]), which is why it is probed via mtk_clk_pdev_probe. [1] https://lore.kernel.org/all/20250828080855.3502514-8-paul-pl.chen@mediatek.com/ (local) Best, Laura