Thread (8 messages) 8 messages, 4 authors, 2026-03-04

Re: [PATCH v7 1/4] dt-bindings: backlight: Add max25014 support

From: Maud Spierings <maudspierings@gocontroll.com>
Date: 2026-02-10 08:51:17
Also in: dri-devel, imx, linux-devicetree, linux-fbdev, linux-leds, lkml

On 1/29/26 17:04, Rob Herring wrote:
On Fri, Jan 23, 2026 at 12:31:30PM +0100, Maud Spierings wrote:
quoted
The Maxim MAX25014 is a 4-channel automotive grade backlight driver IC
with integrated boost controller.

Signed-off-by: Maud Spierings <maudspierings@gocontroll.com>

---

In the current implementation the control registers for channel 1,
control all channels. So only one led subnode with led-sources is
supported right now. If at some point the driver functionality is
expanded the bindings can be easily extended with it.
---
  .../bindings/leds/backlight/maxim,max25014.yaml    | 91 ++++++++++++++++++++++
  MAINTAINERS                                        |  5 ++
  2 files changed, 96 insertions(+)
diff --git a/Documentation/devicetree/bindings/leds/backlight/maxim,max25014.yaml b/Documentation/devicetree/bindings/leds/backlight/maxim,max25014.yaml
new file mode 100644
index 000000000000..c499e6224a8f
--- /dev/null
+++ b/Documentation/devicetree/bindings/leds/backlight/maxim,max25014.yaml
@@ -0,0 +1,91 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/leds/backlight/maxim,max25014.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Maxim max25014 backlight controller
+
+maintainers:
+  - Maud Spierings <maudspierings@gocontroll.com>
+
+properties:
+  compatible:
+    enum:
+      - maxim,max25014
+
+  reg:
+    maxItems: 1
+
quoted
+  "#address-cells":
+    const: 1
+
+  "#size-cells":
+    const: 0
No child nodes (with addresses), so these should be dropped. And in the
example.

With that,

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
And in the actual dtso's too, thanks for spotting this, this passed the 
dts check but indeed is not correct anymore.

kind regards,
Maud

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help