Re: [PATCH v9 11/12] sched: add need-resched timed wait interface
From: bot+bpf-ci@kernel.org
Date: 2026-02-09 03:05:45
Also in:
bpf, linux-arch, linux-pm, lkml
From: bot+bpf-ci@kernel.org
Date: 2026-02-09 03:05:45
Also in:
bpf, linux-arch, linux-pm, lkml
The wait is implemented via smp_cond_load_relaxed_timeout(). smp_cond_load_acquire_timeout() essentially provides the pattern used in poll_idle() where we spin in a loop waiting for the flag to change until a timeout occurs.
This isn't a bug, but the commit message mentions smp_cond_load_acquire_timeout() when describing the poll_idle() pattern. However, the code uses smp_cond_load_relaxed_timeout(), and the subsequent poll_idle() conversion (patch 12/12) also uses the relaxed variant via tif_need_resched_relaxed_wait(). Should this say smp_cond_load_relaxed_timeout() instead of smp_cond_load_acquire_timeout() for consistency with the implementation? --- AI reviewed your patch. Please fix the bug or email reply why it's not a bug. See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md CI run summary: https://github.com/kernel-patches/bpf/actions/runs/21810635323 AI-authorship-score: low AI-authorship-explanation: The commit follows standard kernel style with iterative improvements across 9 versions and reviewer feedback, consistent with human authorship. issues-found: 1 issue-severity-score: low issue-severity-explanation: Minor commit message inaccuracy referencing wrong function name, no impact on code correctness or runtime behavior.