RE: [PATCH 2/4] irqchip/ast2700-intcx: Add AST2700 INTC0/INTC1 support

Subject: RE: [PATCH 2/4] irqchip/ast2700-intcx: Add AST2700 INTC0/INTC1
support

On Sat, Feb 07 2026 at 03:50, Ryan Chen wrote:

quoted

quoted

-----Original Message-----
From: Thomas Gleixner <redacted>
Sent: Friday, February 6, 2026 7:34 PM
To: Ryan Chen <ryan_chen@aspeedtech.com>; Rob Herring
[off-list ref]; Krzysztof Kozlowski [off-list ref]; Conor
Dooley [off-list ref]; Joel Stanley [off-list ref]; Andrew
Jeffery [off-list ref]; Paul Walmsley
[off-list ref]; Palmer Dabbelt [off-list ref]; Albert Ou
[off-list ref]; Alexandre Ghiti [off-list ref]
Cc: linux-kernel@vger.kernel.org; devicetree@vger.kernel.org;
linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org;
linux-riscv@lists.infradead.org; Ryan Chen [off-list ref]
Subject: Re: [PATCH 2/4] irqchip/ast2700-intcx: Add AST2700
INTC0/INTC1 support

Please fix your email client to not copy all mail headers. If you can't fix it,
remove them manually and replace it with the usual:

Sorry, This is my mistake. 

On Fri, Feb 06 2026 at ...., Thomas Gleixner wrote:

quoted

quoted

quoted

+	guard(raw_spinlock_irqsave)(&intc0->intc_lock);

s/_irqsave// Interrupts are disabled when this is invoked.

Sorry, do you mean when this function been call.
Ther have desc->lock to do the raw_spin_lock_irqsave.

The core always holds irq_desc::lock with interrupts disabled when it invokes
those irqchip callbacks. So trying to disable interrupts in them again is a
pointless exercise.

Thanks your gyudabce , understood.