Thread (17 messages) 17 messages, 3 authors, 2026-03-08

Re: [PATCH v2 1/3] dt-bindings: display: nuvoton: add MA35D1 DCU binding

From: Joey Lu <hidden>
Date: 2026-02-06 07:05:31
Also in: dri-devel, linux-devicetree, lkml

On 2/5/2026 9:18 PM, Krzysztof Kozlowski wrote:
On Thu, Jan 29, 2026 at 12:05:30PM +0800, Joey Lu wrote:
quoted
+
+  clocks:
+    items:
+      - description: DCU Gate clock for register access
+      - description: DCU Pixel clock for display timing
+
+  clock-names:
+    items:
+      - const: dcu_gate
That's bus or apb
quoted
+      - const: dcup_div
That's pixel

Use descriptive names of functions here. Not your clock controller. It
is completely irrelevant whether you provide here gate or div or mux or
whatever else. If by any chance in new design you put here mux, not div,
then completely new binding?


Best regards,
Krzysztof
I'll use functional clock names bus & pixel instead.

Joey

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help