Hi Krzysztof:

EXTERNAL EMAIL

On 05/02/2026 11:39, Gary Yang wrote:

quoted

Hi Krzysztof:

I'm glad to see your comments

quoted

EXTERNAL EMAIL

On Wed, Feb 04, 2026 at 10:06:42AM +0800, Gary Yang wrote:

quoted

There are two system control on Cix sky1 Soc. One is located in S0
domain, and the other is located in S0 and S5 domain. The system
control contains resets, usb typeC and more. At this point, only the
reset controller child is described as usb typeC uses it by phandle.

Signed-off-by: Gary Yang <redacted>
---
 .../soc/cix/cix,sky1-system-control.yaml      |  49 ++++++
 include/dt-bindings/reset/cix,sky1-rst-fch.h  |  42 +++++
 include/dt-bindings/reset/cix,sky1-rst.h      | 164

++++++++++++++++++

quoted

 3 files changed, 255 insertions(+)
 create mode 100644
Documentation/devicetree/bindings/soc/cix/cix,sky1-system-control.ya
ml  create mode 100644 include/dt-bindings/reset/cix,sky1-rst-fch.h
 create mode 100644 include/dt-bindings/reset/cix,sky1-rst.h

diff --git
a/Documentation/devicetree/bindings/soc/cix/cix,sky1-system-control.
ya
ml
b/Documentation/devicetree/bindings/soc/cix/cix,sky1-system-control.
ya
ml
new file mode 100644
index 000000000000..5fb6b97c3c00

--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/cix/cix,sky1-system-cont
+++ ro
+++ l.yaml

@@ -0,0 +1,49 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2
+---
+$id:
+http://devicetree.org/schemas/soc/cix/cix,sky1-system-control.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Cix Sky1 SoC system control register region
+
+maintainers:
+  - Gary Yang <gary.yang@cixtech.com>
+
+description:
+  An wide assortment of registers of the system controller on Sky1
+SoC,
+  including resets, usb, wakeup sources and so on.
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - cix,sky1-system-control
+          - cix,sky1-s5-system-control
+      - const: syscon
+      - const: simple-mfd

Drop simple-mfd, no children

Yes, just now there is no child nodes. We want to reserve it for further.
If you feel confuse, we can also delete this strings.

Sorry, you cannot reserve it. Bindings should be complete (see writing
bindings), so you should post a COMPLETE binding for this device now.

Adding ABI for "reserved case" is poor idea, because you will have to support it
forever.

quoted

quoted

quoted

+
+  reg:
+    maxItems: 1
+
+  '#address-cells':

Drop, no children

The same as above

quoted

quoted

+    const: 1
+
+  '#size-cells':

Drop

same

quoted

Do you see any recent simple-mfd binding written like this? There are
no. Did you read any of other bindings before sending this? Or at
least my slides or amny other resources from vast documentation from

elinux.org?

quoted

quoted

This yaml comes from microchip,mpfs-mss-top-sysreg.yaml as conor's

suggestions on V3.

quoted

More info:
https://patchwork.kernel.org/project/linux-arm-kernel/patch/2025112406
3235.952136-2-gary.yang@cixtech.com/

Please point to a specific message, not entire thread of 8 untrimmed replies.

Please pay attention to these below:

Three, In corresponding driver files, we can get the regmap pointers via syscon API.
All right? By the way, How should we describe syscon in yaml file? Are there some files used to refer?

microchip,mpfs-mss-top-sysreg.yaml is one I wrote recently. Going to the
corresponding driver you will be able to see how the reset controller
driver is probed. You should be able to find it in linux-next.
sophgo,sg2044-top-syscon.yaml is another that works in the same way

quoted

If you have the different views, please give more information. Thanks

These are simply wrong in this context.

If you claim you might need it, it means you actually need to finish the binding
with missing pieces. Look, do you write such Cc code:

int some_probe() {
        ...

        if (0) {
                /* Code reserved for future */
        }

        return 0;
}

No. Creating unused code means more maintenance, wasted review, wasted
cycles of preprocessor or compiler. We NEVER write such code.

quoted

If miss any information, please remind me.

Yeah, please post COMPLETE bindings for this device.

Yes, I agree your views. we will delete "simple-mfd" strings next version.
Thanks for your advices.

Best Regards
Gary

Best regards,
Krzysztof