[PATCH v5 04/10] dt-bindings: soc: google: gs101-pmu: allow power domains as children
From: André Draszik <andre.draszik@linaro.org>
Date: 2026-02-05 21:42:35
Also in:
linux-devicetree, linux-pm, linux-samsung-soc, lkml
Subsystem:
open firmware and flattened device tree bindings, the rest · Maintainers:
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Linus Torvalds
The power domains are a property of / implemented in the PMU. As such,
they should be modelled as child nodes of the PMU.
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: André Draszik <andre.draszik@linaro.org>
---
v4:
- consistent quoting using " (Krzysztof)
- add samsung,dtzpc to example
Note: Ideally, the newly added properties (ranges, etc.) should only be
'required' if "^power-domain@[0-9a-f]+$" exists as a patternProperty,
as they're needed only in that case. As-is, this patch now causes
warnings for existing DTs as they don't specify the new properties (and
they shouldn't need to). Only if DTs are updated to include
power-domains, such an update should also add the new properties.
I've not been able to come up with the correct schema syntax to achieve
that. dependencies, dependentRequired, and dependentSchemas don't seem
to support patterns. Similarly,
- if:
required:
- ...
then:
required:
- ...
doesn't allow patterns in the 'if' block (or I didn't get the syntax
right).
Rob said in
https://lore.kernel.org/all/20251010141357.GA219719-robh@kernel.org/ (local)
that this is a known limitation in json-schema.
---
.../bindings/soc/google/google,gs101-pmu.yaml | 41 ++++++++++++++++++++++
1 file changed, 41 insertions(+)
diff --git a/Documentation/devicetree/bindings/soc/google/google,gs101-pmu.yaml b/Documentation/devicetree/bindings/soc/google/google,gs101-pmu.yaml
index a06bd8ec3c20faf0b364d3d3ef1763502c2b09cf..c1ee9575092a3ab17873d228a88468addb62d838 100644
--- a/Documentation/devicetree/bindings/soc/google/google,gs101-pmu.yaml
+++ b/Documentation/devicetree/bindings/soc/google/google,gs101-pmu.yaml@@ -16,6 +16,14 @@ properties: reg: maxItems: 1 + "#address-cells": + const: 1 + + "#size-cells": + const: 1 + + ranges: true + reboot-mode: $ref: /schemas/power/reset/syscon-reboot-mode.yaml type: object
@@ -39,9 +47,23 @@ properties: description: Phandle to PMU interrupt generation interface. +patternProperties: + "^power-domain@[0-9a-f]+$": + type: object + description: Child node describing one power domain within the PMU + + additionalProperties: true + + properties: + compatible: + const: google,gs101-pd + required: - compatible - reg + - '#address-cells' + - '#size-cells' + - ranges - google,pmu-intr-gen-syscon additionalProperties: false
@@ -51,6 +73,25 @@ examples: system-controller@17460000 { compatible = "google,gs101-pmu"; reg = <0x17460000 0x10000>; + #address-cells = <1>; + #size-cells = <1>; + ranges; google,pmu-intr-gen-syscon = <&pmu_intr_gen>; + + pd_g3d: power-domain@1e00 { + compatible = "google,gs101-pd"; + reg = <0x1e00 0x80>; + #power-domain-cells = <0>; + label = "g3d"; + samsung,dtzpc = <&pd_g3d>; + }; + + power-domain@2000 { + compatible = "google,gs101-pd"; + reg = <0x2000 0x80>; + #power-domain-cells = <0>; + power-domains = <&pd_g3d>; + label = "embedded_g3d"; + }; };
--
2.53.0.rc2.204.g2597b5adb4-goog