Hi Heiko,

On Thu, Feb 05, 2026 at 01:50:34PM +0100, Heiko Stübner wrote:

Hi Willy,

Am Montag, 28. Juli 2025, 21:01:54 Mitteleuropäische Normalzeit schrieb Willy Tarreau:

quoted

On Tue, Apr 15, 2025 at 06:32:03PM +0800, Kever Yang wrote:

quoted

From: Finley Xiao <redacted>

This adds the necessary data for handling otp on the rk3562.

Signed-off-by: Finley Xiao <redacted>
Signed-off-by: Kever Yang <redacted>

Successfully tested with Jonas' patches on top of it on my
Radxa E20C (RK3528):

Tested-by: Willy Tarreau <w@1wt.eu>

as you replied to the rk3562 variant, does that mean the rk3528
uses the same variant data?

Now you make me doubt, I'll have to recheck the original message
in its series and the patches that I had applied. I seem to
rememeber there were certain common patches between the two but
I don't remember which ones, and it's also possibly that I replied
by accident to the wrong message in the series or that I mistook
one patch for another when comparing them :-/

Ah, I seem to have found it, there's indeed the 3562 in my local
patches and the 3528 as well, both of which rely on the 3568 one:

  commit a68433c468c8a9d4789641eb6a40ae571fb7f01f
  Author: Finley Xiao [off-list ref]
  Date:   Tue Apr 15 18:32:03 2025 +0800

    nvmem: rockchip-otp: Add support for RK3562
    
    This adds the necessary data for handling otp on the rk3562.
    
    Signed-off-by: Finley Xiao [off-list ref]
    Signed-off-by: Kever Yang [off-list ref]
    Reviewed-by: Heiko Stuebner [off-list ref]
    Signed-off-by: Jonas Karlman [off-list ref]

and:

  commit 249b07e24d3d1d47b7ec23d5f09a56837b66d7f5
  Author: Jonas Karlman [off-list ref]
  Date:   Sun Mar 16 00:05:45 2025 +0000

    nvmem: rockchip-otp: Add support for RK3528
    
    Add support for the OTP controller in RK3528. The OTPC is similar to the
    OTPC in RK3562 and RK3568, exept for a missing phy clock and reset.
    
    Signed-off-by: Jonas Karlman [off-list ref]

It's very possible that I visually mistook one for the other when
responding to the series, and if so, I'm really sorry about that!

The former relies on rk3568_data and the latter on rk3528_data, which
is defined like this:

+static const char * const rk3528_otp_clocks[] = {
+       "otp", "apb_pclk", "sbpi",
+};
+
+static const struct rockchip_data rk3528_data = {
+       .size = 0x80,
+       .word_size = sizeof(u16),
+       .clks = rk3528_otp_clocks,
+       .num_clks = ARRAY_SIZE(rk3528_otp_clocks),
+       .reg_read = rk3568_otp_read,
+};

Looks like the patches originally come from this branch that I
manually cherry-picked:

  https://github.com/Kwiboo/linux-rockchip/commits/next-20250620-rk3528

I have one extra E20C that's not yet in prod if you're interested in
me running some specific tests. It will not happen quickly but just let
me know if I can help, as it's a nice little machine.

Willy