Re: [PATCH v10 2/7] i2c: xiic: remove duplicate error message
From: Jonathan Cameron <jonathan.cameron@huawei.com>
Date: 2026-02-04 10:01:08
Also in:
linux-devicetree, linux-i2c, lkml
On Wed, 04 Feb 2026 07:01:59 +0000 Abdurrahman Hussain via B4 Relay [off-list ref] wrote:
From: Abdurrahman Hussain <abdurrahman@nexthop.ai> The devm_request_threaded_irq() already prints an error message. Remove the duplicate. Reviewed-by: Andy Shevchenko <redacted> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Abdurrahman Hussain <abdurrahman@nexthop.ai>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
quoted hunk ↗ jump to hunk
--- drivers/i2c/busses/i2c-xiic.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index 16ff83fe280b..4cb7c40fb565 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c@@ -1491,11 +1491,8 @@ static int xiic_i2c_probe(struct platform_device *pdev) ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, xiic_process, IRQF_ONESHOT, pdev->name, i2c); - - if (ret < 0) { - dev_err_probe(&pdev->dev, ret, "Cannot claim IRQ\n"); + if (ret) return ret; - } i2c->singlemaster = of_property_read_bool(pdev->dev.of_node, "single-master");