Thread (20 messages) 20 messages, 5 authors, 2026-02-04

Re: [PATCH v9 6/7] i2c: xiic: use numbered adapter registration

From: Andrew Lunn <andrew@lunn.ch>
Date: 2026-02-03 18:31:32
Also in: linux-devicetree, linux-i2c, lkml

On Tue, Feb 03, 2026 at 10:14:49AM -0800, Abdurrahman Hussain wrote:
quoted
On Feb 3, 2026, at 7:45 AM, Andy Shevchenko [off-list ref] wrote:

On Mon, Feb 02, 2026 at 08:37:23PM +0000, Abdurrahman Hussain via B4 Relay wrote:
quoted
Use i2c_add_numbered_adapter() to allow platform devices to specify
fixed bus numbers when needed.
Not sure about this. Doesn't it break the current approach? Please, double
check that.

-- 
With Best Regards,
Andy Shevchenko
If pdev->id is PLATFORM_DEVID_NONE(-1) then i2c_add_numbered_adapter()
falls back to dynamic allocation and calls i2c_add_adapter().

Many existing i2c drivers use the same approach, see i2c-pxa.c and
i2c-pnx.c etc.
It is not about if other drivers do this. Its about does this change
the behaviour of this driver, so that I2C busses get different IDs
then before, and so cause regressions?

You need to explain in the commit message why you think this is safe.

    Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help