On Wed, 2026-01-28 at 13:56 +0100, Lorenzo Bianconi wrote:

quoted

quoted

+	if (drv_set_eml_op_mode(sdata, &sta->sta, &eml_params))
+		return;
+
+	ieee80211_send_eml_op_mode_notif(sdata, mgmt, opt_len);

IMHO it would make more sense to pass "ptr, opt_len" rather than "mgmt,
opt_len", since that's just what gets copied and then the callee doesn't
need to dig it out.

But I guess we need mgmt pointer to set even other fields (e.g. dst-addr,
dialog_token, ecc.).

Yeah, good point, passing them all individually isn't great either.

johannes