Re: [PATCH] phy: PHY_GOOGLE_USB should depend on ARCH_GOOGLE
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2026-01-29 08:32:50
Also in:
linux-phy, linux-samsung-soc, lkml
Hi André, On Wed, 28 Jan 2026 at 21:03, André Draszik [off-list ref] wrote:
On Tue, 2026-01-27 at 20:12 +0100, Geert Uytterhoeven wrote:quoted
The Google Tensor SoC USB PHY is only present on Google Tensor G5 (Laguna) SoCs. Hence add a dependency on ARCH_GOOGLE, to prevent asking the user about this driver when configuring a kernel without Google Tensor SoC support. Fixes: cbce66669c82ee9a ("phy: Add Google Tensor SoC USB PHY driver") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- ARCH_GOOGLE is not yet upstream, but that doesn't hurt.I can see your point, and have no objection, but for context, Greg had asked to not add dependencies on a config option that might or might not get added in the future - ARCH_GOOGLE:
The exact name may indeed still be under discussion. But we all know there _will_ be a config option (unless the platform is abandoned before upstreaming, and this driver will be removed again anyway ;-).
Maybe an alternative would be to make it default=n, and change that default once ARCH_GOOGLE gets added?
It already defaults to disabled, as "default=n" is the default.
quoted
--- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig@@ -49,6 +49,7 @@ config GENERIC_PHY_MIPI_DPHY config PHY_GOOGLE_USB tristate "Google Tensor SoC USB PHY driver" + depends on ARCH_GOOGLE || COMPILE_TEST select GENERIC_PHY help Enable support for the USB PHY on Google Tensor SoCs, starting with
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds