Re: [v4,4/4] stmmac: s32: enable support for Multi-IRQ mode
From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-01-29 05:10:06
Also in:
imx, linux-devicetree, lkml, netdev
This is an AI-generated review of your patch. The human sending this email has considered the AI review valid, or at least plausible. For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html --- stmmac: s32: enable support for Multi-IRQ mode Enables Multi-IRQ mode for the S32 GMAC driver when per-queue IRQs are present and more than one RX queue is configured.
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-s32.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-s32.c index 5a485ee98fa7..37a5b7b46973 100644
[ ... ]
quoted hunk ↗ jump to hunk
@@ -149,6 +149,16 @@ static int s32_dwmac_probe(struct platform_device *pdev) plat->core_type = DWMAC_CORE_GMAC4; plat->pmt = 1; plat->flags |= STMMAC_FLAG_SPH_DISABLE; + + /* Check for multi-IRQ config. Assumption: symetrical rx/tx queues */
^^^^^^^^^^ This isn't a bug, but "symetrical" should be "symmetrical".