Re: [PATCH v6 1/7] dt-bindings: i2c: xiic: make clocks optional

On Wed, Jan 28, 2026 at 03:34:02PM +0100, Andrew Lunn wrote:

On Wed, Jan 28, 2026 at 12:21:41PM +0100, Michal Simek wrote:

quoted

On 1/28/26 11:37, Krzysztof Kozlowski wrote:

quoted

On Tue, Jan 27, 2026 at 09:03:55PM +0000, Abdurrahman Hussain wrote:

quoted

The xiic driver is designed to operate without explicit clock configuration

And if you change this in the driver, then you change bindings?

You miss here explanation based on hardware - how does the hardware work
if nothing ticks it clocks?

Hardware obviously have clock input which needs to be connected. Without it
it won't work.

Should ACPI potential limitations be making the DT description less
accurate?

We absolutely should not be cocking up bindings because ACPI requires
less complete descriptions.

Would it not be better that the driver has an DT binding and an ACPI
binding? Where there are common properties, common functions can be
used to retrieve them. However, if ACPI lacks usable clocks, use the
of_ method to get the clock from DT, and skip it for ACPI.

    Andrew