Re: [PATCH v3] clk: vf610: Add support for the Ethernet switch clocks

Hi Peng,

Hi Lukasz,

quoted

Subject: [PATCH v3] clk: vf610: Add support for the Ethernet switch
clocks

The vf610 device has built in the MoreThanIP L2 switch. For proper
operation it is required to enable ESW and MAC table lookup clocks.

The MAC table spans from 0x400E_C000 for 0x4000 and it is necessary
to provide clocks for each AIPS1-"slot", which size is 0x1000 (hence
four separate entries).

Those can be enabled via clock gating CCM_CCGR10 register
(0x4006_B068).

This patch also adds VF610_CLK_ESW and
VF610_CLK_ESW_MAC_TAB{0123} macros definitions for L2 switch.

The VF610_CLK_END has been removed from dt-bindings, as its
number had to be increased when MTIP L2 switch clocks were added,
and defined locally in clk-vf610.c driver.

Signed-off-by: Lukasz Majewski <redacted>
---
Changes for v2:
- Squash clock DT bindings to this single patch  

Sorry for not being clear in last comment, dt-binding
update should be in a separate patch. So please
separate into two patches in one patchset.

Ok, so I will add dt-binding as a separate comment and as Andrew asked
I will add comment to vf610-clock.h about VF610_CLK_END being moved to
clock driver as a "local" definition.

Thanks,
Peng.

-- 
Best regards,

Lukasz Majewski

--
Nabla Software Engineering GmbH
HRB 40522 Augsburg
Phone: +49 821 45592596
E-Mail: office@nabladev.com
Managing Director : Stefano Babic