Thread (17 messages) 17 messages, 4 authors, 2026-01-28

Re: [PATCH 04/10] ASoC: rockchip: spdif: Use dev_err_probe

From: Sebastian Reichel <hidden>
Date: 2026-01-27 22:12:33
Also in: linux-rockchip, linux-sound, lkml

Hello Alexey,

On Tue, Jan 27, 2026 at 09:31:18PM +0400, Alexey Charkov wrote:
quoted
        ret = devm_snd_dmaengine_pcm_register(&pdev->dev, NULL, 0);
-       if (ret) {
-               dev_err(&pdev->dev, "Could not register PCM\n");
-               return ret;
-       }
+       if (ret)
+               dev_err_probe(&pdev->dev, ret, "Could not register PCM\n");
Shouldn't this one return the error code, instead of falling through
to 'return 0'?
Yes, good catch. I will fix that up in v2.

Thanks,

-- Sebastian

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help