Re: [PATCH] firmware: imx: scu-pd: Fix device_node reference leak in imx_sc_pd_get_console_rsrc()
From: Ulf Hansson <hidden>
Date: 2026-01-27 14:27:51
Also in:
imx, linux-pm, lkml
On Wed, 21 Jan 2026 at 15:17, Felix Gu [off-list ref] wrote:
When calling of_parse_phandle_with_args(), the caller is responsible
to call of_node_put() to release the reference of device node.
In imx_sc_pd_get_console_rsrc(), it does not release the reference.
Fixes: 893cfb99734f ("firmware: imx: scu-pd: do not power off console domain")
Signed-off-by: Felix Gu <redacted>Applied for next by amending the commit-msg-header, thanks! Kind regards Uffe
quoted hunk ↗ jump to hunk
--- drivers/pmdomain/imx/scu-pd.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/pmdomain/imx/scu-pd.c b/drivers/pmdomain/imx/scu-pd.c index 01d465d88f60..3ec33667a308 100644 --- a/drivers/pmdomain/imx/scu-pd.c +++ b/drivers/pmdomain/imx/scu-pd.c@@ -326,6 +326,7 @@ static void imx_sc_pd_get_console_rsrc(void) return; imx_con_rsrc = specs.args[0]; + of_node_put(specs.np); } static int imx_sc_get_pd_power(struct device *dev, u32 rsrc)--- base-commit: 053966c344dbd346e71305f530e91ea77916189f change-id: 20260121-b4-scu-pd-257a9a40e84e Best regards, -- Felix Gu [off-list ref]