Re: [PATCH v2 03/10] arm64: mm: Permit contiguous descriptors to be rewritten
From: Ryan Roberts <ryan.roberts@arm.com>
Date: 2026-01-27 09:45:56
Also in:
linux-hardening, lkml
On 26/01/2026 09:26, Ard Biesheuvel wrote:
From: Ard Biesheuvel <ardb@kernel.org> Currently, pgattr_change_is_safe() is overly pedantic when it comes to descriptors with the contiguous hint attribute set, as it rejects assignments even if the old and the new value are the same. So relax the check to allow that.
But why do we require the relaxation? Why are we re-writing a PTE in the first place? Either the caller already knows it's the same in which case it can be avoided, or it doesn't know in which case it is accidentally the same and couple probably just as easily been accidentally different? So it's better to warn regardless I would think? I'm sure I'll get to the patch where this matters and change my mind :)
quoted hunk ↗ jump to hunk
Signed-off-by: Ard Biesheuvel <ardb@kernel.org> --- arch/arm64/mm/mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c index c36422a3fae2..9d39de3cfe67 100644 --- a/arch/arm64/mm/mmu.c +++ b/arch/arm64/mm/mmu.c@@ -141,7 +141,7 @@ bool pgattr_change_is_safe(pteval_t old, pteval_t new) return false; /* live contiguous mappings may not be manipulated at all */ - if ((old | new) & PTE_CONT) + if ((old | new) & PTE_CONT && old != new) return false; /* Transitioning from Non-Global to Global is unsafe */