On Thu, Jan 22, 2026 at 9:24 PM Florian Fainelli
[off-list ref] wrote:

On 1/21/2026 11:42 PM, Andy Shevchenko wrote:

quoted

On Thu, Jan 22, 2026 at 3:06 AM Florian Fainelli
[off-list ref] wrote:

...

quoted

quoted

+               if (priv->suspended && bank->wake_active & (u32)status) {

Why casting?

status is an unsigned long, which is what for_each_set_bit() expects, so
it is intended here to ensure the top bits are not participating in the
comparison, I think this is just being extra explicit with intent here.

Isn't that guaranteed by the C standard?

quoted

quoted

+                       priv->suspended = false;
+                       pm_wakeup_event(&priv->pdev->dev, 0);
+               }

-- 
With Best Regards,
Andy Shevchenko