Thread (32 messages) 32 messages, 6 authors, 2026-02-03

Re: [PATCH v1 1/2] dt-bindings: ethernet: eswin: add clock sampling control

From: Bo Gan <hidden>
Date: 2026-01-23 10:42:52
Also in: linux-devicetree, lkml, netdev

Hi Krzysztof,

On 1/23/26 02:07, Krzysztof Kozlowski wrote:
On 23/01/2026 08:39, Bo Gan wrote:
quoted
quoted
I assume the address of the interface is fixed. So you can just key
off that to distinguish the two instances.

Since this is an internal property, not a board property, it is not
clear it actually belongs on DT.

      Andrew
IMO, they should be in DT to provide maximum flexibility. The SoC .dtsi
This is not the purpose of DT. Please rather use arguments in terms of
DT rules (see docs, presentations).
Any examples? links? Thank you for your patience.

I'd say if the board .dts never overrides the eswin,rx-clk-invert, (E.g.,
the SoC .dtsi has rx-clk-invert, later the board /delete-property/'s it)
then yes, it can be treated as something inherent to the mac, and then
"use arguments in terms of DT rules". I was thinking about use cases like:
https://lore.kernel.org/all/20230714104521.18751-3-samin.guo@starfivetech.com/ (local)
We really do not care about maximum flexibility.

Best regards,
Krzysztof
Bo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help