Thread (11 messages) 11 messages, 2 authors, 2026-01-22

Re: [PATCH v3 1/6] rtc: zynqmp: declare dependency on arch

From: Michal Simek <michal.simek@amd.com>
Date: 2026-01-22 12:38:37
Also in: linux-rtc, lkml


On 1/22/26 13:25, Tomas Melin wrote:
Hi,

On 21/01/2026 14:16, Michal Simek wrote:
quoted

On 1/19/26 10:51, Tomas Melin wrote:
quoted
Driver is compatible with RTC controller found on zynqmp.
Configure dependency to enable building only when zynqmp architecture
is enabled.

Reported-by: kernel test robot <redacted>
Signed-off-by: Tomas Melin <redacted>
---
   drivers/rtc/Kconfig | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index 2933c41c77c88e60df721fe65b9c8afb995ae51e..46b497524cbfb5d0c1662dcaddbb6d28b4ae2abe 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig
@@ -1376,7 +1376,7 @@ config RTC_DRV_OPTEE
   
   config RTC_DRV_ZYNQMP
   	tristate "Xilinx Zynq Ultrascale+ MPSoC RTC"
-	depends on OF && HAS_IOMEM
+	depends on OF && HAS_IOMEM && ARCH_ZYNQMP

     arm-linux-gnueabi-ld: drivers/rtc/rtc-zynqmp.o: in function
`xlnx_rtc_read_offset':
  >> rtc-zynqmp.c:(.text.xlnx_rtc_read_offset+0xd0): undefined reference to
`__aeabi_ldivmod'

You should use macros like div_u64() to fix it instead of have driver enabled
only for ZynqMP.
I can do it that way if you prefer such approach.
Definitely because this driver could be called from different architectures. 
RISC-V or x86.

Thanks,
Michal
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help