Re: [PATCH v2 2/2] i2c: xiic: make the clock optional
From: Andy Shevchenko <hidden>
Date: 2026-01-22 09:01:55
Also in:
linux-i2c, lkml
From: Andy Shevchenko <hidden>
Date: 2026-01-22 09:01:55
Also in:
linux-i2c, lkml
On Thu, Jan 22, 2026 at 08:32:32AM +0000, Abdurrahman Hussain via B4 Relay wrote:
The xiic driver is designed to operate without explicit clock configuration when clocks are not specified in the firmware. This functionality is already implemented in xiic_setclk(), which performs an early return when either i2c_clk or input_clk are zero: This condition is satisfied when clocks are missing, as clk_get_rate(NULL) returns zero, allowing the driver to rely on hardware-configured timing.
Hmm... Sounds to me like a fix to the early introduced feature. Might worth to add Fixes tag and make this to be the first patch in the series. Either way, LGTM, Reviewed-by: Andy Shevchenko <redacted> -- With Best Regards, Andy Shevchenko