Thread (36 messages) 36 messages, 6 authors, 2026-01-21

Re: [PATCH v6 08/11] PCI: dwc: Invoke post_init in dw_pcie_resume_noirq()

From: Bjorn Helgaas <helgaas@kernel.org>
Date: 2026-01-20 22:04:42
Also in: imx, linux-devicetree, linux-pci, lkml

On Fri, Jan 09, 2026 at 09:27:50AM -0600, Bjorn Helgaas wrote:
...
The current commit log for this patch is this:

  Some SoCs like i.MX95 require enabling REFCLK after resuming from suspend
  in their post_init callback. So invoke the callback at the end of
  dw_pcie_resume_noirq() if available.

When .post_init() is called, the link is already up and PCIe devices
have already been enumerated.  I think REFCLK is required for the link
to come up, so it doesn't sound right to me that .post_init() would be
*enabling* REFCLK.
This never got resolved.

https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=controller/dwc-imx6&id=199c18221622
says imx_pcie_host_post_init() enables REFCLK by applying the
IMX_PCIE_FLAG_8GT_ECN_ERR051586 workaround.

I don't think that commit log is correct.  Can you please supply some
correct text for that commit?

Bjorn
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help