Re: [PATCH v2 1/8] drm/rockchip: vop2: Switch impossible format conditional to WARN_ON
From: Thomas Zimmermann <tzimmermann@suse.de>
Date: 2026-01-20 12:49:14
Also in:
dri-devel, linux-rockchip, lkml
Hi Am 06.12.25 um 21:45 schrieb Nicolas Frattaroli:
quoted hunk ↗ jump to hunk
From: Daniel Stone <redacted> We should never be able to create a framebuffer with an unsupported format, so throw a warning if this ever happens, instead of attempting to stagger on. Signed-off-by: Daniel Stone <redacted> Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com> --- drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c index 498df0ce4680..20b49209ddcd 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c@@ -1030,7 +1030,8 @@ static int vop2_plane_atomic_check(struct drm_plane *plane, return 0; format = vop2_convert_format(fb->format->format); - if (format < 0) + /* We shouldn't be able to create a fb for an unsupported format */ + if (WARN_ON(format < 0))
Please use drm_WARN_ON() here. Best regards Thomas
return format; /* Co-ordinates have now been clipped */
-- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)