Re: [PATCH 2/2] mailbox: zynqmp-ipi: Simplify with scoped for each OF child loop
From: Jassi Brar <jassisinghbrar@gmail.com>
Date: 2026-01-18 20:51:51
Also in:
linux-mediatek, lkml
On Wed, Dec 24, 2025 at 5:45 AM Krzysztof Kozlowski [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Use scoped for-each loop when iterating over device nodes to make code a bit simpler. Signed-off-by: Krzysztof Kozlowski <redacted> --- drivers/mailbox/zynqmp-ipi-mailbox.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c index 967967b2b8a9..42d2583e44ca 100644 --- a/drivers/mailbox/zynqmp-ipi-mailbox.c +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c@@ -904,7 +904,7 @@ static void zynqmp_ipi_free_mboxes(struct zynqmp_ipi_pdata *pdata) static int zynqmp_ipi_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; - struct device_node *nc, *np = pdev->dev.of_node; + struct device_node *np = pdev->dev.of_node; struct zynqmp_ipi_pdata *pdata; struct of_phandle_args out_irq; struct zynqmp_ipi_mbox *mbox;@@ -940,13 +940,12 @@ static int zynqmp_ipi_probe(struct platform_device *pdev) pdata->num_mboxes = num_mboxes; mbox = pdata->ipi_mboxes; - for_each_available_child_of_node(np, nc) { + for_each_available_child_of_node_scoped(np, nc) { mbox->pdata = pdata; mbox->setup_ipi_fn = ipi_fn; ret = zynqmp_ipi_mbox_probe(mbox, nc); if (ret) { - of_node_put(nc); dev_err(dev, "failed to probe subdev.\n"); ret = -EINVAL; goto free_mbox_dev; --2.51.0
Applied to mailbox/for-next. Thanks.