Re: [PATCH] spi: rockchip: Use plain request_irq()
From: Shawn Lin <shawn.lin@rock-chips.com>
Date: 2026-01-16 15:35:07
Also in:
linux-rockchip, linux-spi, lkml
在 2026/01/16 星期五 21:23, Mark Brown 写道:
The Rockchip driver has since interrupt support was added used request_threaded_irq() but not actually supplied a threaded handler, handling everything in the primary handler. This is equivalent to just using a plain request_irq(), and since aef30c8d569c (genirq: Warn about using IRQF_ONESHOT without a threaded handler) the current behaviour has triggered a WARN_ON(). Convert to use request_irq().
Is it preferred to use threaded version if latency is not a critical concern ? I guess the original intention was to use ret = devm_request_threaded_irq(&pdev->dev, ret, NULL, rockchip_spi_isr, IRQF_ONESHOT, dev_name(&pdev->dev), ctlr); ?
quoted hunk ↗ jump to hunk
Reported-by: Aishwarya TCV <redacted> Signed-off-by: Mark Brown <broonie@kernel.org> --- drivers/spi/spi-rockchip.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c index 1a6381de6f33..62e1bc08c940 100644 --- a/drivers/spi/spi-rockchip.c +++ b/drivers/spi/spi-rockchip.c@@ -805,8 +805,8 @@ static int rockchip_spi_probe(struct platform_device *pdev) if (ret < 0) goto err_put_ctlr; - ret = devm_request_threaded_irq(&pdev->dev, ret, rockchip_spi_isr, NULL, - IRQF_ONESHOT, dev_name(&pdev->dev), ctlr); + ret = devm_request_irq(&pdev->dev, ret, rockchip_spi_isr, 0, + dev_name(&pdev->dev), ctlr); if (ret) goto err_put_ctlr;--- base-commit: 0f61b1860cc3f52aef9036d7235ed1f017632193 change-id: 20260115-spi-rockchip-threaded-irq-b1641d0d3919 Best regards, -- Mark Brown [off-list ref] _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip