Re: [PATCH v2 1/5] dt-bindings: clock: google,gs101-clock: fix alphanumeric ordering
From: Peter Griffin <peter.griffin@linaro.org>
Date: 2026-01-13 10:01:33
Also in:
linux-clk, linux-devicetree, linux-samsung-soc, lkml
Hi André On Tue, 13 Jan 2026 at 09:58, André Draszik [off-list ref] wrote:
Hi Peter, On Tue, 2026-01-13 at 09:13 +0000, Peter Griffin wrote:quoted
Hi André, On Mon, 12 Jan 2026 at 14:26, André Draszik [off-list ref] wrote:quoted
On Mon, 2026-01-12 at 14:16 +0000, Peter Griffin wrote:quoted
Fix the places that don't have correct alphanumeric ordering. This will make reasoning about where to add future entries more straightforward. Signed-off-by: Peter Griffin <peter.griffin@linaro.org> --- Documentation/devicetree/bindings/clock/google,gs101-clock.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)diff --git a/Documentation/devicetree/bindings/clock/google,gs101-clock.yamlb/Documentation/devicetree/bindings/clock/google,gs101- clock.yaml index 09e679c1a9def03d53b8b493929911ea902a1763..a8176687bb773ae90800b9c256bcccebfdef2e49 100644--- a/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml +++ b/Documentation/devicetree/bindings/clock/google,gs101-clock.yaml@@ -27,13 +27,13 @@ description: | properties: compatible: enum: - - google,gs101-cmu-top - google,gs101-cmu-apm - - google,gs101-cmu-misc - google,gs101-cmu-hsi0 - google,gs101-cmu-hsi2 + - google,gs101-cmu-misc - google,gs101-cmu-peric0 - google,gs101-cmu-peric1 + - google,gs101-cmu-topIf we keep 'top' at the top as one outlier, it'd reflect that it is the top unit and all other CMUs are children of it.Thanks for the review. I opted to just keep it alphanumeric so it's (hopefully) obvious what all future ordering should be.One last comment: except that all other source files in the tree place cmu_top at the top. It'd be more consistent with those files if done similarly here.
I agree :) I just saw your other review comments in clk-gs101 and realized what you meant here. I forgot CMU_TOP is at the top of the C file (which makes sense when reading the driver as it feeds all the other CMUs). Will update. Thanks, Peter.