Re: [PATCH v5 2/2] arm64: dts: ti: Add TQ-Systems TQMa62xx SoM and MBa62xx carrier board Device Trees
From: Nishanth Menon <nm@ti.com>
Date: 2026-01-12 11:50:18
Also in:
linux-devicetree, linux-hardening, lkml
On 12:21-20260112, Matthias Schiffer wrote: [...]
quoted
quoted
+ + lvds_panel_pins: lvds-panel-pins { + pinctrl-single,pins = < + /* (N20) GPMC0_BE1n.GPIO0_36 - LVDS0_RESET# */ + AM62X_IOPAD(0x0094, PIN_OUTPUT, 7)Could you follow the comment convention you have elsewhere? please follow the same in gpio below etc.. AM62X_IOPAD(....) /* (N20) ... */I tried to avoid making the lines overly long an adhered to the regular 100 column limit where reasonable. I agree that the current inconsistent style is not so nice... I see two options here: - Consistently move the comment to a separate line - Break long comments including pin name, pin function and board signal function into two lines
I am not holding 100char limit for pinmux definitions, just pick a consistent style through out. [...]
quoted
quoted
diff --git a/arch/arm64/boot/dts/ti/k3-am625-tqma62xx.dtsi b/arch/arm64/boot/dts/ti/k3-am625-tqma62xx.dtsi new file mode 100644 index 0000000000000..1b7d58cb7b936 --- /dev/null +++ b/arch/arm64/boot/dts/ti/k3-am625-tqma62xx.dtsi@@ -0,0 +1,331 @@ +// SPDX-License-Identifier: GPL-2.0-only OR MIT +/* + * Copyright (C) 2021-2022 Texas Instruments Incorporated - https://www.ti.com/ + * Copyright (c) 2023-2025 TQ-Systems GmbH <linux@ew.tq-group.com>, D-82229 Seefeld, Germany. + * Author: Matthias Schiffer + */[...]quoted
+ regulators { + reg_buck1: buck1 { + regulator-name = "V_VDD_CORE"; + regulator-min-microvolt = <750000>; + regulator-max-microvolt = <750000>; + regulator-boot-on; + regulator-always-on; + }; +[...]quoted
+ +&a53_opp_table { + opp-1400000000 { + opp-hz = /bits/ 64 <1400000000>; + opp-supported-hw = <0x01 0x0004>; + opp-suspend; + clock-latency-ns = <6000000>; + /* Enabled by bootloader if supported */ + status = "disabled";This (bootloader enabling just this node) wont work unless vdd_core voltage is configured to 0.8v as well, no?Correct, the bootloader patches both PMIC config and OPP table.
add documentation in regulator node as well, please. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D https://ti.com/opensource