[PATCH v3] scsi: ufs: exynos: call phy_notify_state() from hibern8 callbacks
From: Peter Griffin <peter.griffin@linaro.org>
Date: 2026-01-09 11:40:30
Also in:
linux-samsung-soc, linux-scsi, lkml
Subsystem:
scsi subsystem, the rest, universal flash storage host controller driver exynos hooks · Maintainers:
"James E.J. Bottomley", "Martin K. Petersen", Linus Torvalds, Alim Akhtar
Notify the ufs phy of the hibern8 link state so that it can program the appropriate values. Signed-off-by: Peter Griffin <peter.griffin@linaro.org> --- Note: The phy_notify_state() API is part of v6.19-rc1 and onwards. --- Changes in v3: - Add 'static const' (Bart) - Drop Barts reviewed-by tag for now - Link to v2: https://lore.kernel.org/r/20260107-ufs-exynos-phy_notify_pmstate-v2-1-2b823a25208b@linaro.org (local) Changes in v2: - Collect up tags - Rebased onto next-20260106 - Update phy_notify_pmstate() to phy_notify_state() - Link to v1: https://lore.kernel.org/r/20250703-ufs-exynos-phy_notify_pmstate-v1-1-49446d7852d1@linaro.org (local) --- drivers/ufs/host/ufs-exynos.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c
index 70d195179ebaa01f38331faaee6f8349211c4c3b..76fee3a79c77b7117a2c02f380f8c78d702ad173 100644
--- a/drivers/ufs/host/ufs-exynos.c
+++ b/drivers/ufs/host/ufs-exynos.c@@ -1568,12 +1568,17 @@ static void exynos_ufs_pre_hibern8(struct ufs_hba *hba, enum uic_cmd_dme cmd) { struct exynos_ufs *ufs = ufshcd_get_variant(hba); struct exynos_ufs_uic_attr *attr = ufs->drv_data->uic_attr; + static const union phy_notify phystate = { + .ufs_state = PHY_UFS_HIBERN8_EXIT + }; if (cmd == UIC_CMD_DME_HIBER_EXIT) { if (ufs->opts & EXYNOS_UFS_OPT_BROKEN_AUTO_CLK_CTRL) exynos_ufs_disable_auto_ctrl_hcc(ufs); exynos_ufs_ungate_clks(ufs); + phy_notify_state(ufs->phy, phystate); + if (ufs->opts & EXYNOS_UFS_OPT_USE_SW_HIBERN8_TIMER) { static const unsigned int granularity_tbl[] = { 1, 4, 8, 16, 32, 100
@@ -1600,12 +1605,17 @@ static void exynos_ufs_pre_hibern8(struct ufs_hba *hba, enum uic_cmd_dme cmd) static void exynos_ufs_post_hibern8(struct ufs_hba *hba, enum uic_cmd_dme cmd) { struct exynos_ufs *ufs = ufshcd_get_variant(hba); + static const union phy_notify phystate = { + .ufs_state = PHY_UFS_HIBERN8_ENTER + }; if (cmd == UIC_CMD_DME_HIBER_ENTER) { ufs->entry_hibern8_t = ktime_get(); exynos_ufs_gate_clks(ufs); if (ufs->opts & EXYNOS_UFS_OPT_BROKEN_AUTO_CLK_CTRL) exynos_ufs_enable_auto_ctrl_hcc(ufs); + + phy_notify_state(ufs->phy, phystate); } }
--- base-commit: 6cd6c12031130a349a098dbeb19d8c3070d2dfbe change-id: 20250703-ufs-exynos-phy_notify_pmstate-c0e9db95ac66 Best regards, -- Peter Griffin [off-list ref]