Re: [PATCH V1] i2c: imx: Fix SMBus block read hang on zero length
From: Andi Shyti <andi.shyti@kernel.org>
Date: 2026-01-07 20:13:29
Also in:
imx, linux-i2c, lkml
Hi, Can anyone from Pengutronix give this patch a look and possibly a try? Oleksij? On Mon, Dec 29, 2025 at 08:16:29AM +0000, LI Qingwu wrote:
SMBus block read transfers encode the payload length in the first data byte. When this first byte is zero, there is no payload and the transaction should terminate immediately. On i.MX, if the first byte of an SMBus block read is zero, the driver unconditionally overwrites the state with IMX_I2C_STATE_READ_CONTINUE. This causes the state machine to enter an endless read loop, eventually overrunning internal buffers and leading to a crash. At the same time, the controller remains in master receive mode and never generates a proper STOP condition, leaving the I2C bus permanently busy and preventing any further transfers on the bus. Fix this by handling the zero-length case explicitly: when the first byte is zero, ensure that a clean STOP is generated. In this situation the controller is in master receive mode, so it must be switched to master transmit mode before stopping. This is done by draining the pending received byte from I2DR, setting I2CR_MTX to enter transmit mode, waiting briefly for the mode change, and then proceeding with the normal STOP sequence. This change has been tested on i.MX 8M Plus platform. Signed-off-by: LI Qingwu <redacted>
Is this a fix?
quoted hunk ↗ jump to hunk
--- drivers/i2c/busses/i2c-imx.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c index dcce882f3eba..f40deecf0f66 100644 --- a/drivers/i2c/busses/i2c-imx.c +++ b/drivers/i2c/busses/i2c-imx.c@@ -735,6 +735,16 @@ static void i2c_imx_stop(struct imx_i2c_struct *i2c_imx, bool atomic) temp = imx_i2c_read_reg(i2c_imx, IMX_I2C_I2CR); if (!(temp & I2CR_MSTA)) i2c_imx->stopped = 1; + if ((temp & I2CR_MSTA) && !(temp & I2CR_MTX)) { + (void)imx_i2c_read_reg(i2c_imx, IMX_I2C_I2DR);
why do we need a cast here?
+ temp |= I2CR_MTX; + imx_i2c_write_reg(temp, i2c_imx, IMX_I2C_I2CR); + if (atomic) + udelay(25);
where is this 25 coming from?
+ else + usleep_range(25, 50); + temp = imx_i2c_read_reg(i2c_imx, IMX_I2C_I2CR);
Thanks, Andi