On Mon, 2026-01-05 at 09:05 +0100, Nicolas Frattaroli wrote:

On Wednesday, 24 December 2025 07:16:34 Central European Standard
Time Peter Wang (王信友) wrote:

quoted

On Thu, 2025-12-18 at 13:54 +0100, Nicolas Frattaroli wrote:

quoted

-
-static void ufs_mtk_init_boost_crypt(struct ufs_hba *hba)
+static int ufs_mtk_init_boost_crypt(struct ufs_hba *hba)

Hi Nicolas,

Please do not change the return type if you are not checking the
return
value.




Should free the cfg memory?

It's a devres alloc. It'll get freed on driver removal automatically.
Freeing it manually would be a double-free once the driver unloads.

Hi Nicolas,

Got it. Please feel free to add my review tag when you correct the
return type.

Thanks.
Peter