Thread (7 messages) 7 messages, 6 authors, 2026-01-09

Re: [PATCH] pinctrl: meson: mark the GPIO controller as sleeping

From: Neil Armstrong <neil.armstrong@linaro.org>
Date: 2026-01-05 15:07:57
Also in: linux-amlogic, linux-gpio, lkml, stable

On 1/5/26 16:05, Bartosz Golaszewski wrote:
quoted hunk ↗ jump to hunk
The GPIO controller is configured as non-sleeping but it uses generic
pinctrl helpers which use a mutex for synchronization.

This can cause the following lockdep splat with shared GPIOs enabled on
boards which have multiple devices using the same GPIO:

BUG: sleeping function called from invalid context at
kernel/locking/mutex.c:591
in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 142, name:
kworker/u25:3
preempt_count: 1, expected: 0
RCU nest depth: 0, expected: 0
INFO: lockdep is turned off.
irq event stamp: 46379
hardirqs last  enabled at (46379): [<ffff8000813acb24>]
_raw_spin_unlock_irqrestore+0x74/0x78
hardirqs last disabled at (46378): [<ffff8000813abf38>]
_raw_spin_lock_irqsave+0x84/0x88
softirqs last  enabled at (46330): [<ffff8000800c71b4>]
handle_softirqs+0x4c4/0x4dc
softirqs last disabled at (46295): [<ffff800080010674>]
__do_softirq+0x14/0x20
CPU: 1 UID: 0 PID: 142 Comm: kworker/u25:3 Tainted: G C
6.19.0-rc4-next-20260105+ #11963 PREEMPT
Tainted: [C]=CRAP
Hardware name: Khadas VIM3 (DT)
Workqueue: events_unbound deferred_probe_work_func
Call trace:
   show_stack+0x18/0x24 (C)
   dump_stack_lvl+0x90/0xd0
   dump_stack+0x18/0x24
   __might_resched+0x144/0x248
   __might_sleep+0x48/0x98
   __mutex_lock+0x5c/0x894
   mutex_lock_nested+0x24/0x30
   pinctrl_get_device_gpio_range+0x44/0x128
   pinctrl_gpio_set_config+0x40/0xdc
   gpiochip_generic_config+0x28/0x3c
   gpio_do_set_config+0xa8/0x194
   gpiod_set_config+0x34/0xfc
   gpio_shared_proxy_set_config+0x6c/0xfc [gpio_shared_proxy]
   gpio_do_set_config+0xa8/0x194
   gpiod_set_transitory+0x4c/0xf0
   gpiod_configure_flags+0xa4/0x480
   gpiod_find_and_request+0x1a0/0x574
   gpiod_get_index+0x58/0x84
   devm_gpiod_get_index+0x20/0xb4
   devm_gpiod_get+0x18/0x24
   mmc_pwrseq_emmc_probe+0x40/0xb8
   platform_probe+0x5c/0xac
   really_probe+0xbc/0x298
   __driver_probe_device+0x78/0x12c
   driver_probe_device+0xdc/0x164
   __device_attach_driver+0xb8/0x138
   bus_for_each_drv+0x80/0xdc
   __device_attach+0xa8/0x1b0

Fixes: 6ac730951104 ("pinctrl: add driver for Amlogic Meson SoCs")
Cc: stable@vger.kernel.org
Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
Closes: https://lore.kernel.org/all/00107523-7737-4b92-a785-14ce4e93b8cb@samsung.com/ (local)
Signed-off-by: Bartosz Golaszewski <redacted>
---
  drivers/pinctrl/meson/pinctrl-meson.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/meson/pinctrl-meson.c b/drivers/pinctrl/meson/pinctrl-meson.c
index 18295b15ecd9..4507dc8b5563 100644
--- a/drivers/pinctrl/meson/pinctrl-meson.c
+++ b/drivers/pinctrl/meson/pinctrl-meson.c
@@ -619,7 +619,7 @@ static int meson_gpiolib_register(struct meson_pinctrl *pc)
  	pc->chip.set = meson_gpio_set;
  	pc->chip.base = -1;
  	pc->chip.ngpio = pc->data->num_pins;
-	pc->chip.can_sleep = false;
+	pc->chip.can_sleep = true;
  
  	ret = gpiochip_add_data(&pc->chip, pc);
  	if (ret) {
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Thanks,
Neil
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help