Re: [PATCH 1/3] ata: ahci-dwc: Simplify with scoped for each OF child loop
From: Jonathan Cameron <jonathan.cameron@huawei.com>
Date: 2026-01-05 10:52:57
Also in:
imx, linux-ide, lkml, llvm
On Fri, 2 Jan 2026 13:50:41 +0100 Krzysztof Kozlowski [off-list ref] wrote:
Use scoped for-each loop when iterating over device nodes to make code a bit simpler. Signed-off-by: Krzysztof Kozlowski <redacted>
A whilst you are here suggestion inline to make it a bit simpler.
quoted hunk ↗ jump to hunk
--- drivers/ata/ahci_dwc.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)diff --git a/drivers/ata/ahci_dwc.c b/drivers/ata/ahci_dwc.c index aec6d793f51a..bfd24772ee67 100644 --- a/drivers/ata/ahci_dwc.c +++ b/drivers/ata/ahci_dwc.c@@ -260,7 +260,6 @@ static void ahci_dwc_init_timer(struct ahci_host_priv *hpriv) static int ahci_dwc_init_dmacr(struct ahci_host_priv *hpriv) { struct ahci_dwc_host_priv *dpriv = hpriv->plat_data; - struct device_node *child; void __iomem *port_mmio; u32 port, dmacr, ts;@@ -271,14 +270,12 @@ static int ahci_dwc_init_dmacr(struct ahci_host_priv *hpriv) * the HBA global reset so we can freely initialize it once until the * next system reset. */ - for_each_child_of_node(dpriv->pdev->dev.of_node, child) { + for_each_child_of_node_scoped(dpriv->pdev->dev.of_node, child) { if (!of_device_is_available(child))
for_each_available_child_of_node_scoped()?
continue;
- if (of_property_read_u32(child, "reg", &port)) {
- of_node_put(child);
+ if (of_property_read_u32(child, "reg", &port))
return -EINVAL;
- }
port_mmio = __ahci_port_base(hpriv, port);
dmacr = readl(port_mmio + AHCI_DWC_PORT_DMACR);