Thread (7 messages) 7 messages, 4 authors, 2025-12-30

Re: [PATCH 4/4] mmc: sdhci: aspeed: Simplify with scoped for each OF child loop

From: Ulf Hansson <hidden>
Date: 2025-12-30 15:34:18
Also in: linux-aspeed, linux-mips, linux-mmc, lkml, llvm, openbmc

On Wed, 24 Dec 2025 at 13:44, Krzysztof Kozlowski
[off-list ref] wrote:
Use scoped for-each loop when iterating over device nodes to make code a
bit simpler.

Signed-off-by: Krzysztof Kozlowski <redacted>
All patches in the series applied for next, thanks!

Kind regards
Uffe

quoted hunk ↗ jump to hunk
---
 drivers/mmc/host/sdhci-of-aspeed.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/mmc/host/sdhci-of-aspeed.c b/drivers/mmc/host/sdhci-of-aspeed.c
index ca97b01996b1..4296def69436 100644
--- a/drivers/mmc/host/sdhci-of-aspeed.c
+++ b/drivers/mmc/host/sdhci-of-aspeed.c
@@ -519,7 +519,7 @@ static struct platform_driver aspeed_sdhci_driver = {
 static int aspeed_sdc_probe(struct platform_device *pdev)

 {
-       struct device_node *parent, *child;
+       struct device_node *parent;
        struct aspeed_sdc *sdc;
        int ret;
@@ -548,12 +548,11 @@ static int aspeed_sdc_probe(struct platform_device *pdev)
        dev_set_drvdata(&pdev->dev, sdc);

        parent = pdev->dev.of_node;
-       for_each_available_child_of_node(parent, child) {
+       for_each_available_child_of_node_scoped(parent, child) {
                struct platform_device *cpdev;

                cpdev = of_platform_device_create(child, NULL, &pdev->dev);
                if (!cpdev) {
-                       of_node_put(child);
                        ret = -ENODEV;
                        goto err_clk;
                }
--
2.51.0
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help