Thread (3 messages) 3 messages, 2 authors, 2025-12-28
STALE188d

[PATCH] soc: mediatek: SVS: Fix memory leak in svs_enable_debug_write()

From: Zilin Guan <hidden>
Date: 2025-12-28 12:52:37
Also in: linux-mediatek, lkml
Subsystem: arm/mediatek soc support, the rest · Maintainers: Matthias Brugger, AngeloGioacchino Del Regno, Linus Torvalds

In svs_enable_debug_write(), the buf is allocated via memdup_user_nul().
If kstrtoint() fails, the function returns directly without freeing the
allocated memory, leading to a memory leak.

Fix this by freeing buf before returning the error code.

Fixes: 13f1bbcfb582 ("soc: mediatek: SVS: add debug commands")
Co-developed-by: Jianhao Xu <redacted>
Signed-off-by: Jianhao Xu <redacted>
Signed-off-by: Zilin Guan <redacted>
---
 drivers/soc/mediatek/mtk-svs.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
index f45537546553..691e7e6be654 100644
--- a/drivers/soc/mediatek/mtk-svs.c
+++ b/drivers/soc/mediatek/mtk-svs.c
@@ -799,8 +799,10 @@ static ssize_t svs_enable_debug_write(struct file *filp,
 		return PTR_ERR(buf);
 
 	ret = kstrtoint(buf, 10, &enabled);
-	if (ret)
+	if (ret) {
+		kfree(buf);
 		return ret;
+	}
 
 	if (!enabled) {
 		svs_bank_disable_and_restore_default_volts(svsp, svsb);
-- 
2.34.1

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help