On Wed, Dec 24, 2025 at 11:17:20AM +0800, Jianhua Lin wrote:
Compared to the previous generation IC, the MT8189 uses 34-bit iova
address-space (16GB) and requires a single clock configuration.
Therefore, add "mediatek,mt8189-jpgenc" compatible to the binding document.
Additionally, it corrects the inheritance for MT8188, aligning it
Two different issues. Don't mix them up. See submitting patches.
with MT8189 due to their shared architecture and 34-bit iova address
space (16GB) requirements.
Previously, MT8188 was incorrectly defined alongside SoCs with 32-bit
iova address-space (4GB), such as "mediatek,mtk-jpgenc". This mismatch
results in an ABI break, as MT8188 cannot function correctly under
the 32-bit iova address-space (4GB) configuration.
Key changes include:
How is this related to above?
- Introducing "mediatek,mt8189-jpgenc" as a new compatible string to
represent the correct architecture.
Why are you repeating the same?
- Updating MT8188 to inherit from MT8189, ensuring proper support for
34-bit iova address-space (16GB).
- Add property "mediatek,larb" for MT8189 requirements.
- Improved formatting for better readability and consistency.
These changes ensure that both MT8188 and MT8189 are correctly supported
with the necessary 34-bit iova address-space (16GB), while maintaining
compatibility with their shared architecture.
This is not a contest who writes the longest commit msg by repeating
obvious things.
Extensive internal review and testing have been conducted to validate
these changes and ensure compliance with DT binding standards.
Really, no.
Best regards,
Krzysztof