Thread (1 message) 1 message, 1 author, 2025-12-25

Re: [PATCH v3 6/7] dt-bindings: pinctrl: rockchip: Add RMIO controller binding

flat view

From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-12-25 08:36:40
Also in: linux-devicetree, linux-gpio, linux-rockchip, lkml

On 25/12/2025 04:25, Ye Zhang wrote:
quoted
quoted
+/* RMIO function definition */
+#define RMIO_UART1_TX			1
+#define RMIO_UART1_RX			2
+#define RMIO_UART2_TX			3
+#define RMIO_UART2_RX			4
+#define RMIO_UART3_TX			5
+#define RMIO_UART3_RX			6
+#define RMIO_UART3_CTSN			7
+#define RMIO_UART3_RTSN			8
+#define RMIO_UART4_TX			9
+#define RMIO_UART4_RX			10
+#define RMIO_UART4_CTSN			11
+#define RMIO_UART4_RTSN			12
+#define RMIO_MIPITE			13
+#define RMIO_CLK_32K			14
+#define RMIO_I2C0_SCL			15
+#define RMIO_I2C0_SDA			16
I do not see how this is a binding. Please point me to the patch using
this in the driver.
These macros are intended to be used in the Device Tree sources to 
improve readability, avoiding “magic numbers” for the RMIO function IDs.
That was not my question. Read again what I asked.

So not a binding, remove.


Best regards,
Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help