Re: [PATCH v6 1/4] dt-bindings: clock: google,gs101-clock: add samsung,sysreg property as required
From: Peter Griffin <peter.griffin@linaro.org>
Date: 2025-12-22 09:39:56
Also in:
linux-clk, linux-devicetree, linux-samsung-soc, lkml
Hi Krzysztof, On Sun, 21 Dec 2025 at 13:26, Krzysztof Kozlowski [off-list ref] wrote:
On 20/12/2025 10:05, Peter Griffin wrote:quoted
Each CMU (with the exception of cmu_top) has a corresponding sysreg bank that contains the BUSCOMPONENT_DRCG_EN and optional MEMCLK registers. The BUSCOMPONENT_DRCG_EN register enables dynamic root clock gating of bus components and MEMCLK gates the sram clock. Now the clock driver supports automatic clock mode, to fully enable dynamic root clock gating it is required to configure these registers. Update the bindings documentation so that all CMUs (with the exception of gs101-cmu-top) have samsung,sysreg as a required property. Note this is NOT an ABI break, as if the property isn't specified the clock driver will fallback to the current behaviour of not initializing the registers. The system still boots, but bus components won't benefit from dynamic root clock gating and dynamic power will be higher (which has been the case until now anyway). Additionally update the DT example to included the correct CMU size as registers in that region are used for automatic clock mode. Signed-off-by: Peter Griffin <peter.griffin@linaro.org> --- Changes in v5: - Invert the test for google,gs101-cmu-top (Andre)<form letter> This is a friendly reminder during the review process. It looks like you received a tag and forgot to add it. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions of patchset, under or above your Signed-off-by tag, unless patch changed significantly (e.g. new properties added to the DT bindings). Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. Please read: https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577 If a tag was not added on purpose, please state why and what changed. </form letter>
Apologies, your tag should have been added.... got kind of sidetracked bisecting the linux-next regression with the serial console and then forgot to apply it. Peter.