Re: [PATCH 3/4] arm64: dts: mediatek: add device-tree for Genio 720-EVK board
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-12-03 20:25:58
Also in:
linux-devicetree, linux-mediatek, linux-serial, lkml
On 03/12/2025 14:59, Louis-Alexis Eyraud wrote:
Add support for MediaTek MT8189 SoC and its variants, and a device-tree for the basic hardware enablement of the Genio 720-EVK board, based on MT8391 SoC. MT8391 SoC is a variant of MT8189 SoC with a difference for the Arm Cortex-A78 CPU core maximum frequency (2.6 Ghz for MT8391, 3 Ghz for MT8189). MT8391 hardware register maps are identical to MT8189.
Subject: drop redundant "device-tree for" (not mentioning not correct name even...).
quoted hunk ↗ jump to hunk
The Genio 720-EVK board has following features: - MT8391 SoC - MT6365 PMIC - MT6319 Buck IC - MT6375 Charger IC - 8GB LPDDR5 RAM - 64GB eMMC 5.1 - 128GB UFS - 20V DC Jack - USB Type-C Power Adapter - Micro SD card slot - Push Button x 4 (Power, Reset, Download and Home Key) - LED x 3 (System Power, Reset, DC-IN Power) - USB Type-C Connector (USB 3.2) x 2 - USB Type-C Connector (USB 2.0) x 1 - 3.5mm Earphone Jack x 1 (with Microphone Input) - 3.5mm Line Out Audio Jack x 1 - Analog Microphone x 1 - Digital Microphone x 2 - Gigabit Ethernet with RJ45 connector - DP x 1 (Mode over USB Type-C) - LVDS port x 1 - eDP port x 1 - UART x2 with serial-to-usb converters and USB Type-C connectors - UART Port x 2 on Pin Header - M.2 Slot x 2 - I2C Capacitive Touch Pad - 4-Lane DSI x 1 - 4-Data Lane CSI x 2 - I2S Pin header - 40-Pin 2.54mm Pin Header x 1 - CAN Bus x 1 (RS232 Connector) Signed-off-by: Louis-Alexis Eyraud <redacted> --- arch/arm64/boot/dts/mediatek/Makefile | 1 + arch/arm64/boot/dts/mediatek/mt8189.dtsi | 860 +++++++++++++++++++++ .../boot/dts/mediatek/mt8391-genio-720-evk.dts | 15 + .../boot/dts/mediatek/mt8391-genio-common.dtsi | 555 +++++++++++++ 4 files changed, 1431 insertions(+)diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile index c5fd6191a925ad8fcea401712f7a686e8b0a57c8..e3b63085c0608b86dc8638c9d5e0b73441e9ed7b 100644 --- a/arch/arm64/boot/dts/mediatek/Makefile +++ b/arch/arm64/boot/dts/mediatek/Makefile@@ -110,6 +110,7 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8395-genio-1200-evk.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8395-genio-1200-evk-ufs.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8390-genio-700-evk.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8390-grinn-genio-700-sbc.dtb +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8391-genio-720-evk.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8395-kontron-3-5-sbc-i1200.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8395-radxa-nio-12l.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8395-radxa-nio-12l-8-hd-panel.dtbodiff --git a/arch/arm64/boot/dts/mediatek/mt8189.dtsi b/arch/arm64/boot/dts/mediatek/mt8189.dtsi new file mode 100644 index 0000000000000000000000000000000000000000..bf8a232bcaf10cdf4c590109aea68c9a3e82cc42 --- /dev/null +++ b/arch/arm64/boot/dts/mediatek/mt8189.dtsi@@ -0,0 +1,860 @@ +// SPDX-License-Identifier: (GPL-2.0 OR MIT) +/* + * Copyright (c) 2025 MediaTek Inc. + * + * Copyright (c) 2025 Collabora Ltd. + * Author: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com> + */ + +#include <dt-bindings/clock/mediatek,mt8189-clk.h> +#include <dt-bindings/interrupt-controller/arm-gic.h> +#include <dt-bindings/interrupt-controller/irq.h> + +/ { + compatible = "mediatek,mt8189"; + interrupt-parent = <&gic>; + #address-cells = <2>; + #size-cells = <2>; + + aliases { + i2c0 = &i2c0; + i2c1 = &i2c1; + i2c2 = &i2c2; + i2c3 = &i2c3; + i2c4 = &i2c4; + i2c5 = &i2c5; + i2c6 = &i2c6; + i2c7 = &i2c7; + i2c8 = &i2c8; + mmc0 = &mmc0; + mmc1 = &mmc1; + serial0 = &uart0;
None of above are aliases of the soc. Please move them to the board, because these are properties of the board currently (we did not finish the discussion about soc-aliases, so it cannot be used as reason for above).
+ };
+
+ clk32k: oscillator-clk32k {Either oscillator or clock (clk). Not both. "clock-clk" makes no sense and this is implied by oscillator. Please use name for all fixed clocks which matches current format recommendation: 'clock-<freq>' (see also the pattern in the binding for any other options). https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/clock/fixed-clock.yaml Best regards, Krzysztof