Re: [PATCH 3/3] media: imx-csi: use media_pad_is_streaming helper
From: Frank Li <Frank.li@nxp.com>
Date: 2025-11-07 16:15:01
Also in:
imx, linux-media
On Fri, Nov 07, 2025 at 11:16:35AM +0100, Michael Tretter wrote:
The media_pad_is_streaming helper is explicitly for checking, if a pad has been started with media_pipeline_start. Use it instead of relying on the implicit knowledge, that a pad that has a pipeline is streaming.
Suggested commit message: The media_pad_is_streaming() helper is explicitly intended to check whether a pad has been started with media_pipeline_start(). Use it instead of relying on the implicit assumption that a pad with a pipeline is streaming. Frank
quoted hunk ↗ jump to hunk
Signed-off-by: Michael Tretter <m.tretter@pengutronix.de> --- drivers/staging/media/imx/imx-media-utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/staging/media/imx/imx-media-utils.c b/drivers/staging/media/imx/imx-media-utils.c index 6d69f69c16c1..4ea9b3fc59d0 100644 --- a/drivers/staging/media/imx/imx-media-utils.c +++ b/drivers/staging/media/imx/imx-media-utils.c@@ -774,7 +774,7 @@ int imx_media_pipeline_set_stream(struct imx_media_dev *imxmd, __media_pipeline_stop(pad); } else { v4l2_subdev_call(sd, video, s_stream, 0); - if (media_pad_pipeline(pad)) + if (media_pad_is_streaming(pad)) __media_pipeline_stop(pad); } --2.47.3