Thread (4 messages) 4 messages, 3 authors, 2025-11-21

Re: [PATCH v2] kbuild: Support directory targets for building DTBs

From: Nathan Chancellor <nathan@kernel.org>
Date: 2025-11-21 22:20:35
Also in: linux-kbuild, linux-mips, linux-riscv, lkml

On Fri, Nov 21, 2025 at 08:42:34PM +0100, Nicolas Schier wrote:
Using '$(filter )' instead of '$(findstring )' reduces the risk of false
positives, e.g.:

dtb-targets := %/dts %.dtb %.dtbo dtbs dtbs_check
ifneq ($(findstring /dts/,$(MAKECMDGOALS))$(filter $(dtb-targets),$(MAKECMDGOALS)),)
Oh yeah, that would seem to clear up my concerns.
With (something like) that:
Tested-by: Nicolas Schier <nsc@kernel.org>
Acked-by: Nicolas Schier <nsc@kernel.org>
Agreed.

Acked-by: Nathan Chancellor <nathan@kernel.org>
But [1] seems to break this patch.

[1]: https://lore.kernel.org/linux-kbuild/20251120140645.478623-1-thomas.de_schampheleire@nokia.com (local)
Yeah, that will need to be coordinated, I cc'd Rob on that change for
him to take a look as well.

Cheers,
Nathan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help