Re: [PATCH v2 3/7] soc: samsung: exynos-chipid: use devm action to unregister soc device

On 11/19/25 2:13 PM, Krzysztof Kozlowski wrote:

On 18/11/2025 14:56, Tudor Ambarus wrote:

quoted

Simplify the unwinding of the soc device by using a devm action.
Add the action before the exynos_asv_init() to avoid an explicit call
to soc_device_unregister().

Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
---
 drivers/soc/samsung/exynos-chipid.c | 27 +++++++++++----------------

Can I take the cleanups before new GS support?

Fine by me. I'll send v3 then, to have the cleanups first.> 

That's btw preferred order for all work. Fixes should be independent or
first in the patchset. Then cleanups before features/new support.

I agree for the fixes. In the past I used to do the cleanups before new
support, and I got feedback that the cleanups might delay the integration
of the new support. I'm okay with both approaches, v3 will come.

Thanks,
ta